Adding GCloud federated authentication for teaching-qualifications #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaheislamdfe
force-pushed
the
2143-aytq-migrate-to-gcp-wif
branch
7 times, most recently
from
caa968b to
2f92a92
Compare
shaheislamdfe
had a problem deploying
to
review
GitHub Actions
Failure
shaheislamdfe
force-pushed
the
2143-aytq-migrate-to-gcp-wif
branch
from
2f92a92 to
8d9ed67
Compare
shaheislamdfe
had a problem deploying
to
review
GitHub Actions
Failure
shaheislamdfe
force-pushed
the
2143-aytq-migrate-to-gcp-wif
branch
from
8d9ed67 to
537fb2e
Compare
shaheislamdfe
had a problem deploying
to
review
GitHub Actions
Failure
shaheislamdfe
had a problem deploying
to
review
GitHub Actions
Failure
shaheislamdfe
force-pushed
the
2143-aytq-migrate-to-gcp-wif
branch
from
537fb2e to
7f9a5a3
Compare
shaheislamdfe
had a problem deploying
to
review
GitHub Actions
Failure
shaheislamdfe
had a problem deploying
to
review
GitHub Actions
Failure
vipin-dfe
force-pushed
the
2143-aytq-migrate-to-gcp-wif
branch
from
a469e60 to
2daa906
Compare
|
The review apps Access Your Teaching Qualifications & Check A Teacher's Record have been deleted. |
shaheislamdfe
force-pushed
the
2143-aytq-migrate-to-gcp-wif
branch
from
924a078 to
1669cb0
Compare
shaheislamdfe
force-pushed
the
2143-aytq-migrate-to-gcp-wif
branch
2 times, most recently
from
dc60543 to
ec6c292
Compare
shaheislamdfe
force-pushed
the
2143-aytq-migrate-to-gcp-wif
branch
from
ec6c292 to
2fab66c
Compare
RMcVelia
reviewed
Dec 5, 2024
terraform/application/application.tf
Outdated
| @@ -70,4 +70,5 @@ module "worker_application" { | |||
| replicas = var.worker_replicas | |||
| docker_image = var.docker_image | |||
| enable_logit = true | |||
| enable_gcp_wif = true | |||
There was a problem hiding this comment.
this should be
enable_gcp_wif = var.enable_dfe_analytics_federated_auth
otherwise it enables on all environments
RMcVelia
reviewed
Dec 5, 2024
| with: | ||
| project_id: teaching-qualifications | ||
| workload_identity_provider: projects/708780292301/locations/global/workloadIdentityPools/access-your-teaching-qualificati/providers/access-your-teaching-qualificati | ||
|
|
There was a problem hiding this comment.
delete-review-app.yml will also need updating with gcp login and permissions
shaheislamdfe
force-pushed
the
2143-aytq-migrate-to-gcp-wif
branch
from
2fab66c to
286e3b1
Compare
…cations workspace
shaheislamdfe
force-pushed
the
2143-aytq-migrate-to-gcp-wif
branch
from
286e3b1 to
5840406
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This change is to implement the dfe analytics module which will connect the service worker deployment using workload identity federation.
Changes proposed in this pull request
Adding the dfe_analytics module to the Terraform repo. Adding id-token write permissions to the repo aswell as adding a secret config maps to fetch the google credentials from the dfe analytics module, with dfe analytics enabled in the review environment.
Guidance to review
Developer to validate via the Google Cloud BigQuery workspace project that they can run BigQuery against the service app.
https://github.com/DFE-Digital/access-your-teaching-qualifications/actions/runs/12164162777/job/33925228943
Link to Trello card
https://trello.com/c/Nxs3UM9M/2143-aytq-migrate-to-gcp-wif
Checklist